Add rails 8.1 test #280
Open
Add rails 8.1 test #280
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@Austio What do you make of grncdr's analysis here - #276 (comment) ? IMO he's correct - this log subscriber shouldn't be messing with ActiveRecord's runtime stats. Just deleting the calls would break Rails 5/6 compatibility though, so it might need a version bump. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
See: rails/rails@7d12071
Closes #276 - I cherry picked from zzak here and added specs showing the change passes to reduce burden on maintainer here.
Description of changes
Failing Spec with Adding Rails 8.1 support
Passing Spec with CherryPicking change from zzak