protocol(fictrac_direction_test): drop redundant open-loop waits (single duration knob)#146
Merged
Merged
Conversation
The web runner holds each trial for its trialParams `duration` host-side (hostSideTrialEnd remainder top-up; firmware auto-stop #4 not landed), so a plain display trial needs no `wait`. Remove the paired `wait` from all 12 open-loop trials — `open_dur` is now their single duration field, so the max(trialParams, waits) masking can't happen. The closed-loop trial keeps its wait: it brackets the closed-loop hold (start -> wait -> stop), bound to cl_dur. Totals unchanged: 330 s default; open_dur:3 -> 162 s. Verified against the shared runner math (conditionDuration / flattenStructure). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
mbreiser
added a commit
that referenced
this pull request
Jul 6, 2026
Brings in #144 (closed-loop runner FicTrac apply + in-protocol disconnect + course-repo default), #145/#146 (fictrac_direction_test open_dur/cl_dur durations), #147 (arena-configs sync), #149, and the deploy-pages split. Only conflict was arena_studio.html (2 hunks), resolved: - footer: kept v0.7's one-line footer (the full changelog moved to docs/development/arena-studio-release-notes.md; #144's code auto-merged). - course-repo default: kept #144's Studio.DEFAULT_COURSE_REPO fallback so the Repo field display matches the already-merged courseSettings() resolver and the change handler (all "empty -> course repo"); dropped v0.7's never-set seeding / explicit-clear-sticks nuance in favor of #144's coherent default. #144's runner FicTrac-apply is the fix for the "closed loop doesn't run in the runner" checklist note; keeping it was the point of merging rather than replacing. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Open-loop trials no longer carry a redundant
wait: the runner already holds each trial for its trialParamsdurationhost-side (hostSideTrialEndremainder top-up; firmware auto-stop #4 not landed). So all 12 open-loop trials are now a single trialParams with oneopen_durknob — themax(trialParams, waits)masking that confused a bench user can't happen. The closed-loop trial keeps its wait (it brackets the closed-loop hold, bound tocl_dur).Totals unchanged: 330 s default;
open_dur: 3-> 162 s. Verified against the shared runner math. Also pushed to the course repoprotocols/shared/.🤖 Generated with Claude Code