Conversation
Member
Author
|
Also remove the references to G5 from |
Contributor
|
@floesche -- thanks for the PR! However, I'm going to close this because I will be updating how we're handling arena configs, including generation and will make a larger update next week. At that time, I'll remove the G5 option....so doesn't make sense to review this one because all the changes should be done together, starting with the matlab code |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was confused by G5 being listed in most of the tools. I thought, G5 never worked. Even if it did, I believe the panels had a different number of LEDs?
This PR removes all references to G5, except for the
data/reference_data.jsonfile.