Skip to content

fix(v3): clear dirty flag when undo returns to a saved state (v0.19) #88

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mbreiser merged 1 commit into from
Jun 1, 2026
Merged

fix(v3): clear dirty flag when undo returns to a saved state (v0.19) #88

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions experiment_designer_v3.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1332,7 +1332,7 @@ <h1>v3 Experiment Designer</h1>
<!-- Footer -->
<div class="app-footer">
<a href="https://github.com/reiserlab/webDisplayTools" target="_blank">Reiser Lab</a> |
v3 Experiment Designer v0.18 | <span id="footerTimestamp">2026-06-01 09:10 ET</span>
v3 Experiment Designer v0.19 | <span id="footerTimestamp">2026-06-01 09:26 ET</span>
</div>

<!-- Error modal -->
Expand Down Expand Up @@ -1457,7 +1457,11 @@ <h2 id="modalTitle">Import error</h2>
if (!experiment || !experiment._doc) return null;
return {
text: experiment._doc.toString(),
selection: selection ? JSON.parse(JSON.stringify(selection)) : null
selection: selection ? JSON.parse(JSON.stringify(selection)) : null,
// Capture the dirty flag too, so undoing back to the loaded state
// clears "● edited" (and redo re-asserts it). pushUndo snapshots
// BEFORE the mutation, so this records the pre-edit dirty value.
dirty: dirty
};
}

Expand All @@ -1479,6 +1483,7 @@ <h2 id="modalTitle">Import error</h2>
try {
experiment = parseV3Protocol(snap.text);
selection = snap.selection;
setDirty(!!snap.dirty);
renderAll();
} catch (err) {
showError('Undo/redo restore failed', err.message);
Expand Down
Loading