Fix for support on Alpine and others musl-based distros#44
Merged
reisraff merged 2 commits intoreisraff:masterfrom Jul 3, 2018
igk1972:igk1972-fix-suport-musl
Merged
Fix for support on Alpine and others musl-based distros#44reisraff merged 2 commits intoreisraff:masterfrom igk1972:igk1972-fix-suport-musl
reisraff merged 2 commits intoreisraff:masterfrom
igk1972:igk1972-fix-suport-musl
Conversation
Alpine doesn't support GLOB_BRACE since it is using musl libc instead of GNU libc.
Owner
|
Oh, man, I appreciate your contribution, but since, we had the problem of autoload, we must take on mind that until this line https://github.com/igk1972/phulp/blob/64dd84392b24b5bb873708a0c2268e16f0af4a26/bin/phulp.php#L64 we dont have sure that the autoload was successfuly initialized. So I liked you PR, I just would ask you to change this behavior for, ask the files with glob, and assert the name with regex, that ensure we are not using dependencies on the phulp.php (bootstraper). Thanks man. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Alpine Linux doesn't support GLOB_BRACE since it is using musl libc instead of GNU libc.
I was trying to compile static assets on an Alpine Linux Docker container (popular case). I was unable to, because there is a error around usage of the GLOB_BRACE constant, which may or may not be defined depending on the environment, and isn't defined/worked in Alpine Linux.
Using an Alpine Linux PHP Docker container, for running Phulp:
PHP 7.1 (Alpine Linux 3.7)
The following:
[Exception]
Notice: Use of undefined constant GLOB_BRACE - assumed 'GLOB_BRACE' in /app/php_packages/reisraff/phulp/bin/phulp.php on line 145