fix(sqlite): escape identifiers in PRAGMA queries#10
Merged
rekurt merged 1 commit intoApr 7, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
PRAGMASQL (e.g.PRAGMA table_info("{}")), which can be broken by crafted identifiers containing quotes or semicolons and could lead to parse errors or statement injection.Description
format!(...)interpolation of raw names inPRAGMA table_info,PRAGMA index_list, andPRAGMA index_infowith a safe quoting helper and usequote_identifier(...)when building those statements.quote_identifierhelper that wraps identifiers in double quotes and escapes embedded"by doubling them (SQL-standard identifier quoting).test_quote_identifiercovering normal identifiers and identifiers with embedded quotes.Testing
sqlite::tests::test_quote_identifierand attempted to run it withcargo test --lib sqlite::tests::test_quote_identifier.CONNECT tunnel failed, response 403), so automated tests could not be completed here.Codex Task