Feat/fixes#11
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 068cd060e1
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if let Some((pid, _)) = self.detail_cache.as_ref() { | ||
| if !self | ||
| .session | ||
| .entries | ||
| .iter() | ||
| .any(|entry| entry.entry.process.pid == *pid) | ||
| { | ||
| self.detail_cache = None; | ||
| } | ||
| } |
There was a problem hiding this comment.
When the Processes/Detail view is open, get_process_detail() only re-fetches if the selected PID changes, so this new refresh path keeps the cached detail forever as long as that PID is still present in session.entries. That leaves CPU/RSS, cwd, env, and open-file data stale across auto-refreshes for long-lived processes (and even for Gone entries during the retention window), which regresses the previous per-refresh invalidation behavior. Please either clear the cache each refresh or add a freshness/TTL check before reusing it.
Useful? React with 👍 / 👎.
1 participant
What does this PR do?
Type of change
Checklist
cargo test --workspacepassescargo clippy --workspace --all-targetshas no warningscargo fmt --all -- --checkpassesScreenshots / demo
Related issues