Conversation
We use the gorums: prefix for all runtime panic messages.
Contributor
|
|
Overall Grade |
Security Reliability Complexity Hygiene |
Code Review Summary
| Analyzer | Status | Updated (UTC) | Details |
|---|---|---|---|
| Go | Mar 25, 2026 8:34p.m. | Review ↗ | |
| Shell | Mar 25, 2026 8:34p.m. | Review ↗ |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR standardizes Gorums runtime-facing panic/error strings to consistently use the gorums: prefix (per #301), and updates affected tests/docs to match.
Changes:
- Prefixes several runtime errors and panics with
gorums:(config, manager, node, stream, correctable, test helpers). - Updates config-related tests to assert the new prefixed error strings.
- Adjusts user-guide example error strings for nested calls.
Reviewed changes
Copilot reviewed 10 out of 11 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| testopts.go | Updates panic strings in test helper options to use/retain gorums: prefix. |
| opts_test.go | Formatting-only adjustments in option-splitting tests. |
| node.go | Updates nil-node panic message to use gorums: prefix. |
| mgr.go | Prefixes “node already exists” error with gorums: . |
| internal/stream/channel.go | Prefixes an internal stream invariant panic with gorums: . |
| inbound_manager.go | Changes a static error return to use fmt.Errorf("gorums: ..."). |
| doc/user-guide.md | Updates example error strings in nested QC examples. |
| correctable.go | Prefixes/rewrites a correctable state panic message with gorums: . |
| config_test.go | Updates expected error strings to match the new gorums: -prefixed config errors. |
| config_opts.go | Prefixes config option validation errors with gorums: . |
| config.go | Prefixes config constructor/extend errors and panic with gorums: . |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #301