Skip to content

chore: Make all runtime errors and panics use the gorums: prefix#311

Merged
meling merged 2 commits intomasterfrom
meling/301/chore-gorums-prefix-for-runtime-errors-and-panics
Mar 25, 2026
Merged

chore: Make all runtime errors and panics use the gorums: prefix#311
meling merged 2 commits intomasterfrom
meling/301/chore-gorums-prefix-for-runtime-errors-and-panics

Conversation

@meling
Copy link
Member

@meling meling commented Mar 25, 2026

Fixes #301

@meling meling requested a review from Copilot March 25, 2026 20:34
@deepsource-io
Copy link
Contributor

deepsource-io bot commented Mar 25, 2026

DeepSource Code Review

We reviewed changes in 02f69e1...e0d598f on this pull request. Below is the summary for the review, and you can see the individual issues we found as inline review comments.

See full review on DeepSource ↗

PR Report Card

Overall Grade   Security  

Reliability  

Complexity  

Hygiene  

Code Review Summary

Analyzer Status Updated (UTC) Details
Go Mar 25, 2026 8:34p.m. Review ↗
Shell Mar 25, 2026 8:34p.m. Review ↗

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR standardizes Gorums runtime-facing panic/error strings to consistently use the gorums: prefix (per #301), and updates affected tests/docs to match.

Changes:

  • Prefixes several runtime errors and panics with gorums: (config, manager, node, stream, correctable, test helpers).
  • Updates config-related tests to assert the new prefixed error strings.
  • Adjusts user-guide example error strings for nested calls.

Reviewed changes

Copilot reviewed 10 out of 11 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
testopts.go Updates panic strings in test helper options to use/retain gorums: prefix.
opts_test.go Formatting-only adjustments in option-splitting tests.
node.go Updates nil-node panic message to use gorums: prefix.
mgr.go Prefixes “node already exists” error with gorums: .
internal/stream/channel.go Prefixes an internal stream invariant panic with gorums: .
inbound_manager.go Changes a static error return to use fmt.Errorf("gorums: ...").
doc/user-guide.md Updates example error strings in nested QC examples.
correctable.go Prefixes/rewrites a correctable state panic message with gorums: .
config_test.go Updates expected error strings to match the new gorums: -prefixed config errors.
config_opts.go Prefixes config option validation errors with gorums: .
config.go Prefixes config constructor/extend errors and panic with gorums: .

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@meling meling merged commit aef562f into master Mar 25, 2026
10 of 11 checks passed
@meling meling deleted the meling/301/chore-gorums-prefix-for-runtime-errors-and-panics branch March 25, 2026 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

chore: ensure all errors from the Gorums runtime use the gorums: prefix

2 participants