Fix variable naming conflicts in doctests and documentation accuracy

[Copilot]

Addresses review comments from PR #40 regarding variable naming conflicts in doctest examples and documentation inconsistencies.

Changes

• Documentation: Corrected pattern-construction.md to state "two functionally equivalent ways" (was "three") for creating atomic patterns, reflecting that only point and pure remain after patternWith removal.

• Doctest variable naming: Renamed all variables named pattern to p in Pattern.Core.hs to avoid shadowing the pattern function. Affects Functor and Traversable instance examples.

-- Before (naming conflict)
pattern = pattern "greeting" [elem1, elem2]
fmap (map toUpper) pattern

-- After (no conflict)
p = pattern "greeting" [elem1, elem2]
fmap (map toUpper) p

---

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

---

Note

Documentation cleanup and doctest fixes

• Updates docs/users/api/pattern-construction.md to reflect only two atomic constructors (point, pure) and clarifies that pattern is for patterns with elements
• Renames doctest variables from pattern to p in Pattern/Core.hs Functor and Traversable examples to avoid shadowing the pattern function; no functional code changes

^{Written by Cursor Bugbot for commit 4966c95. This will update automatically on new commits. Configure here.}