Skip to content

chore: support laravel 13 [3.x]#145

Merged
ManukMinasyan merged 4 commits into3.xfrom
chore/laravel-13-support
Apr 28, 2026
Merged

chore: support laravel 13 [3.x]#145
ManukMinasyan merged 4 commits into3.xfrom
chore/laravel-13-support

Conversation

@ManukMinasyan
Copy link
Copy Markdown
Collaborator

Summary

Adds Laravel 13 support to relaticle/custom-fields. The package itself doesn't depend on any Laravel 13-breaking APIs — the only blocker was the transitive dependency on postare/blade-mdi, which is capped at Laravel 12 and unmaintained (open Laravel 13 PRs upstream have sat for over a month with no response).

Changes

composer.json

  • Replace postare/blade-mdi: ^1.0 with manukminasyan/blade-mdi: ^1.1.3. This is a Packagist-published fork of postare/blade-mdi that:
    • Widens the illuminate/support constraint to include ^13.0
    • Keeps the Postare\BladeMdi\ namespace identical, so existing @svg('mdi-...') calls require no changes
    • Declares "replace": { "postare/blade-mdi": "self.version" } so any other package in the dependency tree that requires postare/blade-mdi continues to resolve cleanly
  • Widen orchestra/testbench to ^10.0|^11.0 (testbench 11 covers Laravel 13)

.github/workflows/tests.yml

  • Add laravel: 13.* + testbench: 11.* to the matrix alongside the existing 12.* / 10.* row, so every push runs against both versions

What this does NOT change

  • No source code changes — the package only uses Laravel APIs that are stable across 12 and 13
  • No Filament version bump — still ^5.0
  • No PHP version bump — still ^8.3
  • Existing Laravel 12 users are unaffected

Test plan

  • CI passes on both 12.* and 13.* matrix legs
  • Install in a fresh Laravel 13 app and verify forms render with custom fields
  • Spot-check icon rendering on a custom-fields settings page (icons are served via manukminasyan/blade-mdi)

Copilot AI review requested due to automatic review settings April 28, 2026 14:07
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds Laravel 13 compatibility for relaticle/custom-fields by updating a transitive icon dependency and expanding CI coverage to test against both Laravel 12 and 13.

Changes:

  • Swap postare/blade-mdi for manukminasyan/blade-mdi to remove the Laravel 12-only constraint.
  • Allow orchestra/testbench ^11.0 for Laravel 13 testing.
  • Expand the GitHub Actions test matrix to include a Laravel 13 / Testbench 11 leg.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
composer.json Updates dependencies to support Laravel 13 (via blade-mdi fork) and adds Testbench 11 allowance.
.github/workflows/tests.yml Updates CI matrix to run tests on both Laravel 12 and 13.

Comment thread .github/workflows/tests.yml
Comment thread composer.json
@ManukMinasyan
Copy link
Copy Markdown
Collaborator Author

Addressed in a729b85 — regenerated composer.lock so it now references manukminasyan/blade-mdi v1.1.4 and no longer contains a postare/blade-mdi package entry. The two remaining mentions of postare/blade-mdi in the lockfile are inside the fork's own replace directive ("postare/blade-mdi": "self.version") and a description string, which is expected.

@ManukMinasyan
Copy link
Copy Markdown
Collaborator Author

Verified the GitHub Actions matrix is correct as-is. The L13 CI leg of the previous run actually executed composer require "laravel/framework:13.*" "orchestra/testbench:11.*" --no-interaction --no-update (run 25057985459, job 73403641469, line 14:12:33Z) — both matrix.laravel and matrix.testbench were properly substituted.

This is the documented include expansion behavior: each include entry whose keys don't conflict with the original matrix gets merged into matching combinations. {laravel: 12.*, testbench: 10.*} matches the laravel: 12.* combination and adds testbench: 10.* to it; same for the L13 entry. Docs: https://docs.github.com/en/actions/using-jobs/using-a-matrix-for-your-jobs#expanding-or-adding-matrix-configurations

@ManukMinasyan ManukMinasyan merged commit 25eea51 into 3.x Apr 28, 2026
3 checks passed
@ManukMinasyan ManukMinasyan deleted the chore/laravel-13-support branch April 28, 2026 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants