Merged
Conversation
… add enums to test
… add enums to test
- type EnumHelper::convertEnumToString param as mixed, mark class final, add strict_types - split BackedEnum / UnitEnum branches, throw InvalidArgumentException on unknown objects - convert column ids once inside findColumnsNeedingRebalancing so callers don't re-convert - update unit test to assert the throw
# Conflicts: # tests/Fixtures/StatusEnum.php
Laravel ships Illuminate\Support\enum_value() which handles BackedEnum, UnitEnum, and scalar passthrough — exactly what the helper wrapped. Cast its mixed return to string at the callsite.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added handling grouping enums to the rebalancer.
I put the convertEnumToString() method in its own helper, as there was nowhere obvious to put it. Happy to move it somewhere else.
Added testing of enums to the rebalancer tests, and a unit test for convertEnumToString().