[4.x] Cast id to string to avoid snowflake ids being treated as floats#89
Closed
RhysLees wants to merge 1 commit intorelaticle:4.xfrom
Closed
[4.x] Cast id to string to avoid snowflake ids being treated as floats#89RhysLees wants to merge 1 commit intorelaticle:4.xfrom
RhysLees wants to merge 1 commit intorelaticle:4.xfrom
Conversation
…loosing precision
Contributor
|
Thanks for the fix @RhysLees! Your root cause analysis was spot on. Closing this in favor of #91 (3.x) and #92 (4.x) which apply the fix at the data layer in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using snowflakes instead of standard ids causes ids to be treated as floats changing the id.
for example task.id is 420533451316027392 when using
the snowflake is being treated by js as a float and losing precision so casting to a string resolves this.
Closes #88