Skip to content

Conversation

@1-leo
Copy link
Contributor

@1-leo 1-leo commented Oct 21, 2025

pointycastle: ">=3.0.0 <5.0.0" to improve compatibility, ndk is compatible with v3 and v4.
However other packages are still not updated to v4 making them incompatible with ndk if we pin it to v4.

Same goes for bip340: ">=0.3.0 <0.4.0"

@codecov
Copy link

codecov bot commented Oct 21, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 68.52%. Comparing base (1330581) to head (284f579).
⚠️ Report is 14 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #252   +/-   ##
=======================================
  Coverage   68.52%   68.52%           
=======================================
  Files         126      126           
  Lines        4464     4464           
=======================================
  Hits         3059     3059           
  Misses       1405     1405           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@1-leo 1-leo marked this pull request as ready for review October 21, 2025 09:39
@1-leo 1-leo requested review from frnandu and nogringo October 21, 2025 09:39
@1-leo 1-leo self-assigned this Oct 21, 2025
@1-leo 1-leo added this to ndk-dev Oct 21, 2025
@1-leo 1-leo moved this to In Progress in ndk-dev Oct 21, 2025
@1-leo 1-leo added the dependencies changes to the dependencies, usually upgrades label Oct 21, 2025
@1-leo 1-leo merged commit 0c83055 into master Oct 22, 2025
3 of 4 checks passed
@github-project-automation github-project-automation bot moved this from In Progress to Done in ndk-dev Oct 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies changes to the dependencies, usually upgrades

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants