Skip to content

Conversation

@nogringo
Copy link
Collaborator

@nogringo nogringo commented Nov 3, 2025

No description provided.

@nogringo nogringo requested review from 1-leo and frnandu November 3, 2025 17:31
@codecov
Copy link

codecov bot commented Nov 3, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 68.95%. Comparing base (71f2683) to head (980db62).
⚠️ Report is 30 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #270      +/-   ##
==========================================
+ Coverage   68.93%   68.95%   +0.01%     
==========================================
  Files         129      129              
  Lines        4504     4506       +2     
==========================================
+ Hits         3105     3107       +2     
  Misses       1399     1399              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Collaborator

@frnandu frnandu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's not make tests depend on external stuff like echo.websocket.org, otherwise they'll break when external stuff goes away.

@nogringo nogringo requested review from 1-leo and frnandu November 5, 2025 16:48
@1-leo 1-leo added this to ndk-dev Nov 11, 2025
@1-leo 1-leo moved this to In Progress in ndk-dev Nov 11, 2025
@1-leo 1-leo added the bug Something isn't working label Nov 11, 2025
@nogringo nogringo merged commit ffb72e2 into master Nov 12, 2025
3 checks passed
@github-project-automation github-project-automation bot moved this from In Progress to Done in ndk-dev Nov 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants