-
Notifications
You must be signed in to change notification settings - Fork 5
fix: use isolate.run in bip340 event verifier #345
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #345 +/- ##
==========================================
+ Coverage 70.72% 70.78% +0.05%
==========================================
Files 136 136
Lines 5069 5072 +3
==========================================
+ Hits 3585 3590 +5
+ Misses 1484 1482 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
can we merge #327 (and #332) Used like this: final data = await IsolateManager.instance
.runInComputeIsolate<PARAMTYPE, RETURNTYPE>(
<function>,
<params>
);
final data = await IsolateManager.instance
.runInComputeIsolate<_MiningParams, Nip01Event>(
_mineEventInIsolate,
_MiningParams(
event: event,
targetDifficulty: targetDifficulty,
maxIterations: maxIterations ?? 1000000,
),
);
|
1-leo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
depends if performance-wise verifying a lot of events proves to be noticeable better with |
No description provided.