Skip to content

Nip42 multi account auth#357

Merged
nogringo merged 3 commits intomasterfrom
nip42-multi-account-auth
Jan 22, 2026
Merged

Nip42 multi account auth#357
nogringo merged 3 commits intomasterfrom
nip42-multi-account-auth

Conversation

@nogringo
Copy link
Collaborator

No description provided.

@codecov
Copy link

codecov bot commented Jan 13, 2026

Codecov Report

❌ Patch coverage is 70.00000% with 15 lines in your changes missing coverage. Please review.
✅ Project coverage is 71.55%. Comparing base (75228ab) to head (f41f378).
⚠️ Report is 42 commits behind head on master.

Files with missing lines Patch % Lines
...s/ndk/lib/domain_layer/usecases/relay_manager.dart 80.00% 7 Missing ⚠️
...b/domain_layer/usecases/jit_engine/jit_engine.dart 20.00% 4 Missing ⚠️
...k/lib/domain_layer/usecases/relay_sets_engine.dart 60.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #357      +/-   ##
==========================================
- Coverage   71.68%   71.55%   -0.13%     
==========================================
  Files         142      142              
  Lines        5301     5341      +40     
==========================================
+ Hits         3800     3822      +22     
- Misses       1501     1519      +18     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@nogringo nogringo requested review from 1-leo and frnandu January 13, 2026 17:37
@1-leo
Copy link
Contributor

1-leo commented Jan 14, 2026

why is this needed? Is this for multi account where you want to be logged in as A but want to do just one post as B?

@1-leo
Copy link
Contributor

1-leo commented Jan 14, 2026

  • naming (connection with accouts usecase and authenticateAs)

Copy link
Collaborator

@frnandu frnandu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you give a bit more explaination in docs, which practical usecases for using multi accounts auth on a request/subscription.

@nogringo nogringo force-pushed the nip42-multi-account-auth branch from 5c8669c to 2d22ebc Compare January 16, 2026 12:34
@nogringo nogringo requested review from 1-leo and frnandu January 16, 2026 12:46
@nogringo nogringo merged commit d93664e into master Jan 22, 2026
1 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants