fix: preserve tags and custom fields in metadata#465
Open
fix: preserve tags and custom fields in metadata#465
Conversation
- Add tags field to Metadata entity - Add rawContent field to preserve original JSON - Update fromEvent() to store tags and rawContent - Update toEvent() to merge with original JSON - Add helper methods setCustomField() and getCustomField() - Fix constructor to use mutable list for tags Fixes #438
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #465 +/- ##
==========================================
+ Coverage 76.01% 76.41% +0.39%
==========================================
Files 152 152
Lines 6204 6291 +87
==========================================
+ Hits 4716 4807 +91
+ Misses 1488 1484 -4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
1-leo
requested changes
Feb 25, 2026
Contributor
1-leo
left a comment
There was a problem hiding this comment.
String? get name => content['name'] as String?;
getters are executed every time, because metadata is access frequently this could add up.
Can we cache them? Acessing custom properties should still be possible
Collaborator
Author
|
Should we update toJson and fromJson ? It will be a braking change. |
1-leo
approved these changes
Feb 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #438