Skip to content

fix: remove isar#519

Merged
frnandu merged 1 commit intomasterfrom
fix-remove-isar
Mar 23, 2026
Merged

fix: remove isar#519
frnandu merged 1 commit intomasterfrom
fix-remove-isar

Conversation

@frnandu
Copy link
Copy Markdown
Collaborator

@frnandu frnandu commented Mar 23, 2026

Summary by CodeRabbit

  • Chores
    • Removed Isar-based cache implementation, including all database models, persistence utilities, and configuration files. Isar is no longer available as a caching backend option.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Mar 23, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 20eef03b-1b63-4e8a-968d-10fe17b84e9e

📥 Commits

Reviewing files that changed from the base of the PR and between 78360a5 and fcdad25.

⛔ Files ignored due to path filters (2)
  • packages/isar/libisar.so is excluded by !**/*.so
  • packages/isar/pubspec.lock is excluded by !**/*.lock
📒 Files selected for processing (23)
  • packages/isar/CHANGELOG.md
  • packages/isar/LICENSE
  • packages/isar/README.md
  • packages/isar/codecov.yml
  • packages/isar/lib/data_layer/data_sources/isar_db.dart
  • packages/isar/lib/data_layer/models/db/db_contact_list.dart
  • packages/isar/lib/data_layer/models/db/db_contact_list.g.dart
  • packages/isar/lib/data_layer/models/db/db_event.dart
  • packages/isar/lib/data_layer/models/db/db_event.g.dart
  • packages/isar/lib/data_layer/models/db/db_filter_fetched_range_record.dart
  • packages/isar/lib/data_layer/models/db/db_filter_fetched_range_record.g.dart
  • packages/isar/lib/data_layer/models/db/db_metadata.dart
  • packages/isar/lib/data_layer/models/db/db_metadata.g.dart
  • packages/isar/lib/data_layer/models/db/db_nip05.dart
  • packages/isar/lib/data_layer/models/db/db_nip05.g.dart
  • packages/isar/lib/data_layer/models/db/db_relay_set.dart
  • packages/isar/lib/data_layer/models/db/db_relay_set.g.dart
  • packages/isar/lib/data_layer/models/db/db_user_relay_list.dart
  • packages/isar/lib/data_layer/models/db/db_user_relay_list.g.dart
  • packages/isar/lib/data_layer/repositories/cache_manager/isar_cache_manager.dart
  • packages/isar/lib/ndk_isar.dart
  • packages/isar/pubspec.yaml
  • packages/isar/test/data_layer/cache_manager/isar_cache_manager_test.dart
💤 Files with no reviewable changes (22)
  • packages/isar/README.md
  • packages/isar/LICENSE
  • packages/isar/codecov.yml
  • packages/isar/CHANGELOG.md
  • packages/isar/pubspec.yaml
  • packages/isar/lib/ndk_isar.dart
  • packages/isar/lib/data_layer/data_sources/isar_db.dart
  • packages/isar/test/data_layer/cache_manager/isar_cache_manager_test.dart
  • packages/isar/lib/data_layer/models/db/db_user_relay_list.dart
  • packages/isar/lib/data_layer/models/db/db_event.dart
  • packages/isar/lib/data_layer/models/db/db_contact_list.dart
  • packages/isar/lib/data_layer/models/db/db_filter_fetched_range_record.g.dart
  • packages/isar/lib/data_layer/models/db/db_nip05.dart
  • packages/isar/lib/data_layer/models/db/db_filter_fetched_range_record.dart
  • packages/isar/lib/data_layer/models/db/db_metadata.dart
  • packages/isar/lib/data_layer/models/db/db_relay_set.dart
  • packages/isar/lib/data_layer/models/db/db_event.g.dart
  • packages/isar/lib/data_layer/repositories/cache_manager/isar_cache_manager.dart
  • packages/isar/lib/data_layer/models/db/db_contact_list.g.dart
  • packages/isar/lib/data_layer/models/db/db_relay_set.g.dart
  • packages/isar/lib/data_layer/models/db/db_user_relay_list.g.dart
  • packages/isar/lib/data_layer/models/db/db_nip05.g.dart

📝 Walkthrough

Walkthrough

The entire packages/isar/ package is removed from the codebase, including package metadata, library entrypoint, Isar database models, data layer implementations, repositories, and all associated tests spanning approximately 6,000 lines of code across 21 files.

Changes

Cohort / File(s) Summary
Package Configuration & Metadata
CHANGELOG.md, LICENSE, README.md, codecov.yml, pubspec.yaml
Package manifest and documentation files removed entirely.
Data Layer - Infrastructure
lib/ndk_isar.dart, lib/data_layer/data_sources/isar_db.dart, lib/data_layer/repositories/cache_manager/isar_cache_manager.dart
Core package entrypoint and cache/database implementations deleted, removing Isar initialization, CRUD persistence operations, and event/metadata query logic.
Data Models - Contact List
lib/data_layer/models/db/db_contact_list.dart, lib/data_layer/models/db/db_contact_list.g.dart
Isar collection model and generated schema/query builders for contact list persistence removed.
Data Models - Event
lib/data_layer/models/db/db_event.dart, lib/data_layer/models/db/db_event.g.dart
Isar event model with tag JSON serialization and generated database layer removed (~2,227 LOC).
Data Models - Filter Range & Metadata
lib/data_layer/models/db/db_filter_fetched_range_record.dart, lib/data_layer/models/db/db_filter_fetched_range_record.g.dart, lib/data_layer/models/db/db_metadata.dart
Filter range tracking model and metadata persistence models with generated Isar infrastructure deleted (~1,404 LOC).
Data Models - NIP05 & Relay Set
lib/data_layer/models/db/db_nip05.dart, lib/data_layer/models/db/db_nip05.g.dart, lib/data_layer/models/db/db_relay_set.dart, lib/data_layer/models/db/db_relay_set.g.dart
NIP05 verification records and relay set models with embedded relay/pubkey mappings and generated query/filter/sort extensions removed (~3,561 LOC).
Data Models - User Relay List
lib/data_layer/models/db/db_user_relay_list.dart, lib/data_layer/models/db/db_user_relay_list.g.dart
User relay list collection with embedded relay items and full generated Isar query/update infrastructure removed (~1,520 LOC).
Tests
test/data_layer/cache_manager/isar_cache_manager_test.dart
Integration test suite for cache manager covering persistence/retrieval of all model types deleted.

Estimated code review effort

🎯 4 (Complex) | ⏱️ ~45 minutes

Poem

🐰 With a hop and a bound, I bid thee goodbye,
Isar collections gone, to the digital sky!
No more models to marshal, no schemas to scheme,
Just a cleaner codebase and a rabbit's new dream. 🌙✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'fix: remove isar' clearly and specifically describes the main change—the complete removal of the isar package from the repository, which is evident across all deleted files.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix-remove-isar

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 23, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 73.29%. Comparing base (78360a5) to head (fcdad25).
⚠️ Report is 9 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #519   +/-   ##
=======================================
  Coverage   73.29%   73.29%           
=======================================
  Files         195      195           
  Lines        8969     8969           
=======================================
  Hits         6574     6574           
  Misses       2395     2395           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@frnandu frnandu merged commit 97cecd3 into master Mar 23, 2026
8 checks passed
@frnandu frnandu added this to the 0.8 milestone Mar 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant