Skip to content

dep: replace hex with convert#526

Merged
1-leo merged 1 commit intomasterfrom
chore/bip32-keys-replace-dep
Mar 25, 2026
Merged

dep: replace hex with convert#526
1-leo merged 1 commit intomasterfrom
chore/bip32-keys-replace-dep

Conversation

@1-leo
Copy link
Copy Markdown
Contributor

@1-leo 1-leo commented Mar 25, 2026

removed the outdated hex package and use convert instead

Summary by CodeRabbit

  • Chores
    • Updated internal package dependency for hexadecimal encoding/decoding functionality. No changes to features or public interfaces.

@1-leo 1-leo requested review from frnandu and nogringo March 25, 2026 09:59
@1-leo 1-leo self-assigned this Mar 25, 2026
@1-leo 1-leo added the dependencies changes to the dependencies, usually upgrades label Mar 25, 2026
@1-leo 1-leo added this to ndk-dev Mar 25, 2026
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Mar 25, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 739a42bc-90c6-4388-aa3e-ec64e0df1189

📥 Commits

Reviewing files that changed from the base of the PR and between b9db040 and 6ddc08d.

⛔ Files ignored due to path filters (2)
  • packages/bip32_keys/pubspec.lock is excluded by !**/*.lock
  • packages/drift_cache_manager/pubspec.lock is excluded by !**/*.lock
📒 Files selected for processing (3)
  • packages/bip32_keys/lib/src/bip32_ecurve.dart
  • packages/bip32_keys/lib/src/bip32_slip132.dart
  • packages/bip32_keys/pubspec.yaml

📝 Walkthrough

Walkthrough

The bip32_keys package is migrating its hex encoding/decoding dependency from package:hex to package:convert. Two source files update their imports and method calls accordingly (HEX.decode()hex.decode(), HEX.encode()hex.encode()), while pubspec.yaml reflects the dependency swap. All functional behavior remains identical.

Changes

Cohort / File(s) Summary
Hex Dependency Migration
packages/bip32_keys/lib/src/bip32_ecurve.dart, packages/bip32_keys/lib/src/bip32_slip132.dart
Updated imports from package:hex to package:convert and replaced HEX.decode()/HEX.encode() calls with lowercase hex.decode()/hex.encode() equivalents.
Dependency Update
packages/bip32_keys/pubspec.yaml
Replaced dependency hex: ^0.2.0 with convert: ^3.1.2 in the dependencies section.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

🐰 Hop hop, the hex has gone away,
Convert's here to save the day!
Same decoding, same encode,
Just a fresher package folk. 🎉

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'dep: replace hex with convert' directly and accurately summarizes the main change: replacing the hex package dependency with the convert package across the bip32_keys module.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/bip32-keys-replace-dep

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 25, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 73.33%. Comparing base (b9db040) to head (6ddc08d).
⚠️ Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #526      +/-   ##
==========================================
- Coverage   73.36%   73.33%   -0.04%     
==========================================
  Files         195      195              
  Lines        8969     8969              
==========================================
- Hits         6580     6577       -3     
- Misses       2389     2392       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@1-leo 1-leo merged commit 1c507c9 into master Mar 25, 2026
7 of 8 checks passed
@github-project-automation github-project-automation Bot moved this to Done in ndk-dev Mar 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies changes to the dependencies, usually upgrades

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants