Azure: Allow partial SAS comparison #107
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit changes the Azure's implementation `utils.is_sas_present` function to have a new boolean argument named `base_only` which defaults to `False`. When set as `True` it will cause the SAS comparison to not check for its arguments equivalence, rather just whether the SAS URI part is the same or not. It also changes the `AzurePublishingMetadata` to include a new property named `check_base_sas_only` to transmit its boolean value to the `utils.is_sas_present` function. In practice, this allows the library to have a more permissive SAS comparison when required while maintaning the existing behavior as default. Signed-off-by: Jonathan Gangi <jgangi@redhat.com>
Collaborator
Author
Collaborator
Author
|
@ashwini3326 PTAL as well |
lslebodn
reviewed
May 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit changes the Azure's implementation
utils.is_sas_presentfunction to have a new boolean argument namedbase_onlywhich defaults toFalse. When set asTrueit will cause the SAS comparison to not check for its arguments equivalence, rather just whether the SAS URI part is the same or not.It also changes the
AzurePublishingMetadatato include a new property namedcheck_base_sas_onlyto transmit its boolean value to theutils.is_sas_presentfunction.In practice, this allows the library to have a more permissive SAS comparison when required while maintaning the existing behavior as default.