Skip to content

Azure: Support coreVirtualMachine publishing#18

Merged
JAVGan merged 3 commits into
mainfrom
azure1p
Sep 13, 2024
Merged

Azure: Support coreVirtualMachine publishing#18
JAVGan merged 3 commits into
mainfrom
azure1p

Conversation

@JAVGan

@JAVGan JAVGan commented Aug 9, 2024

Copy link
Copy Markdown
Collaborator

This PR adds support to publish coreVirtualMachine images on Azure for first party publishing.

It has the following changes:

  • Azure: Add CoreVMIPlanTechConfig to the models
  • Add additional VMIProperties for CoreVMImages
  • Dump data to configure as JSON

Relates to ARO-9367

@JAVGan JAVGan changed the title Azure: Add CoreVMIPlanTechConfig to the models WIP: Azure: Support publishing 1p images Aug 9, 2024
@JAVGan

JAVGan commented Aug 9, 2024

Copy link
Copy Markdown
Collaborator Author

@lslebodn @bennerv I've created this branch azure1p to test the support for Azure 1P images... You may checkout this branch on installing the library to see if it works and what else might be required.

I'll keep it as a draft while we're still testing this feature

@JAVGan JAVGan force-pushed the azure1p branch 4 times, most recently from 5707560 to 02c1e42 Compare August 30, 2024 20:54
@JAVGan JAVGan changed the title WIP: Azure: Support publishing 1p images Azure: Support coreVirtualMachine publishing Aug 30, 2024
@JAVGan JAVGan marked this pull request as ready for review August 30, 2024 20:56
@JAVGan

JAVGan commented Aug 30, 2024

Copy link
Copy Markdown
Collaborator Author

@lslebodn @jajreidy This adds support for publishing Azure's coreVirtualMachine images.

It has been tested together with @bennerv to make sure it works as we intended.

Now we just need a small fix on SDK as well as an adjust on cloudimg to add the list permission on SAS URI to properly pass the publishing (we did that manually by patching the library locally).

Once everything is set we will be able properly automate the core publishing

@JAVGan JAVGan force-pushed the azure1p branch 3 times, most recently from 4630736 to 8d4edce Compare September 2, 2024 14:44
This commit adds the `CoreVMIPlanTechConfig` into the Azure models to
support dealing with "Core VM Images".
Add additional VMIProperties found in CoreVMImages
Dump data to configure as JSON

@jajreidy jajreidy left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JAVGan JAVGan merged commit 02b4a05 into main Sep 13, 2024
@JAVGan JAVGan deleted the azure1p branch September 13, 2024 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants