Skip to content

Azure: Remove unnecessary "AZURE_PUBLISHER_NAME"#19

Merged
JAVGan merged 1 commit into
mainfrom
azure_no_publisher
Aug 12, 2024
Merged

Azure: Remove unnecessary "AZURE_PUBLISHER_NAME"#19
JAVGan merged 1 commit into
mainfrom
azure_no_publisher

Conversation

@JAVGan

@JAVGan JAVGan commented Aug 12, 2024

Copy link
Copy Markdown
Collaborator

During 1p tests we found out that the AZURE_PUBLISHER_NAME for Azure Credentials wasn't being used at all in the library's code.

After doing some tests I've confirmed this property is not required, so this commit removes it.

During 1p tests we found out that the `AZURE_PUBLISHER_NAME` for Azure
Credentials wasn't being used at all in the library's code.

After doing some tests I've confirmed this property is not required, so
this commit removes it.
@JAVGan

JAVGan commented Aug 12, 2024

Copy link
Copy Markdown
Collaborator Author

@lslebodn I've confirmed the property AZURE_PUBLISHER_NAME is not required, so let's remove it from out tooling to simplify the lives of our users 😄

@JAVGan JAVGan marked this pull request as ready for review August 12, 2024 18:22

@jajreidy jajreidy left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JAVGan JAVGan merged commit 7a58f15 into main Aug 12, 2024
@JAVGan JAVGan deleted the azure_no_publisher branch August 12, 2024 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants