Allow publishing to draft plans in Azure#4
Merged
Merged
Conversation
This commit creates a new method named `get_product_plan_by_name` which seeks the desired plan name in the product for all available Azure Targets: `draft`, `live`, `preview`. It also changes the `publish` method to use this new method to prevent a bug which a product is found but not the desired plan because it is in the `draft` target. Refers to SPSTRAT-296
Collaborator
Author
|
@lslebodn @ashwini3326 @jajreidy PTAL I'm marking it as READY since the tests I'm making indicates it works. You can find more details about it in the respective JIRA. Note that I also took advantage of this PR to remove some legacy |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit creates a new method named
get_product_plan_by_namewhich seeks the desired plan name in the product for all available Azure Targets:draft,live,preview.It also changes the
publishmethod to use this new method to prevent a bug which a product is found but not the desired plan because it is in thedrafttarget.Refers to SPSTRAT-296