Conversation
Collaborator
Author
This commit changes the `ms_azure.utils.update_skus` function to prevent failures on Azure when dealing with already existing skus. The changes make this function behave as follow: 1. If the plan *has no skus* it will create it for the first time using the default generation informed as the parameter `generation`. 2. If the plan *already has skus* it will just detect which one is the default and then update the values accordingly, to avoid issues with `The property 'PlanId' is locked by a previous submission`. In this case, the argument`generation` is not being activelly used. Refers to SPSTRAT-397
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit changes the
ms_azure.utils.update_skusfunction to prevent failures on Azure when dealing with already existing skus.The changes make this function behave as follow:
If the plan has no skus it will create it for the first time using the default generation informed as the parameter
generation.If the plan already has skus it will just detect which one is the default and then update the values accordingly, to avoid issues with
The property 'PlanId' is locked by a previous submission. In this case, the argumentgenerationis not being activelly used.Refers to SPSTRAT-397