Feature: rpm multiple signatures#253
Merged
guillermodotn merged 3 commits intoMay 21, 2026
Merged
Conversation
Assisted-by: Claude Opus <noreply@anthropic.com>
Assisted-by: Claude Opus <noreply@anthropic.com>
lubomir
reviewed
May 18, 2026
Contributor
lubomir
left a comment
lubomir
left a comment
There was a problem hiding this comment.
Mostly the changes look good to me, but I have two design concerns.
What is the difference between sigkeys being [] and None? They feel similar in meaning, and IMO we should decide on one and standardize on it. If callers can rely on sigkeys always being a list, it might make life easier for them.
The second is about migration to this new implementation. Ideally, I think v2 productmd should only support the list case of sigkeys in API. The code for prepending the single key to the list doesn't seem very useful to me.
Assisted-by: Claude Opus <noreply@anthropic.com>
Contributor
Author
Changes
|
guillermodotn
merged commit 4dc7095
into
release-engineering:development
11 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sigkeysfield to v2.0 RPM entries for packages with multiple signatures (RPM v6).sigkeyis preserved as-is for backward compat.sigkeyis auto-included insigkeyswhen both are provided.Rpms.get_sigkeys()public API.Addresses #206