Skip to content

Conversation

@rohanpm
Copy link
Contributor

@rohanpm rohanpm commented Sep 9, 2019

Our retry policy has custom handling for 404 responses.
The code for that had wrongly assumed that, whenever an exception
had a response attribute, that attribute would be something
other than None.

In practice, the response is None for certain exceptions generated
by the requests library where a failure occurred before a response
was available (e.g. SSL handshake errors, I/O errors). Make sure
we tolerate this, so those exceptions propagate correctly rather
than being transformed to an internal error in the retry policy.

Our retry policy has custom handling for 404 responses.
The code for that had wrongly assumed that, whenever an exception
had a response attribute, that attribute would be something
other than None.

In practice, the response is None for certain exceptions generated
by the requests library where a failure occurred before a response
was available (e.g. SSL handshake errors, I/O errors). Make sure
we tolerate this, so those exceptions propagate correctly rather
than being transformed to an internal error in the retry policy.
@rohanpm rohanpm merged commit 906bf98 into release-engineering:master Sep 10, 2019
@rohanpm rohanpm deleted the 404-fixup branch October 1, 2019 23:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants