minor bug fix and rewrite set-maintenance example script #66
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now the set-maintenance script example takes the --repo-url-regex option and set maintenance mode on based on the relative_url, instead of id when this option is used. Also, fix a minor bug get_maintenance map_404_to_non callback, which the response could be None.
Now the set-maintenance script example takes the --repo-url-regex option and set maintenance mode on based on the relative_url, instead of id when this option is used. Also, fix a minor bug get_maintenance map_404_to_non callback, which the response could be None.
rohanpm
suggested changes
Oct 1, 2019
CHANGELOG.md
Outdated
|
|
||
| - n/a | ||
| ### Fixed | ||
| - Fixed minor bug in map_404_to_none, where the response could have response equals to None |
Contributor
There was a problem hiding this comment.
I don't think this kind of changelog entry makes sense, because there is no map_404_to_none in the API. Can you please describe this in terms that an end-user of the library could understand? How did this bug affect any code using the library?
Contributor
There was a problem hiding this comment.
And since #51 was fixing the same bug in a different piece of code, I guess the commit message / changelog entry there includes some hints.
rohanpm
approved these changes
Oct 2, 2019
rajulkumar
approved these changes
Oct 2, 2019
midnightercz
approved these changes
Oct 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now the set-maintenance script example takes the --repo-url-regex
option and set maintenance mode on based on the relative_url, instead
of id when this option is used.
Also, fix a minor bug get_maintenance map_404_to_non callback, which
the response could be None.