This repository was archived by the owner on Jul 15, 2018. It is now read-only.
relinc/SurePulseDataProcessor #22 fixes filtering issues.#19
Merged
relinc/SurePulseDataProcessor #22 fixes filtering issues.#19
Conversation
Member
|
No behavioral changes^. Just cleanup. I ran unit tests and that worked. I ran it in Trim and that worked. I'm trying to run it from Viewer and it's hanging because the filter is extremely slow if the lowpass value is irrationally small. It freezes up and never recovers. Works good with rational lowpass values. |
Member
|
I forgot to remove the text listener in the Viewer, fixing in relinc/SurePulseDataProcessor#61 |
Member
|
So if you think the hangups with an irrational lowpass value are acceptable, this is ready to merge. I don't know the feasibility of checking the rationality of user input to avoid crashes. |
Contributor
Author
|
Will have to work, for now, I think it eventually works, just takes forever to compute. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds triangular filter and documentation tests.