feat(disk): themed runtime disk-insert MRU picker + dialog button fixes#76
Merged
Conversation
Runtime disk insert (drive-widget click / Disk menu) now opens the themed MRU picker instead of jumping straight to IFileOpenDialog. Lists the same existing-on-disk recents as the boot picker plus DOS 3.3 / ProDOS download rows. A Browse... button preserves the native picker for off-MRU images. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
DialogPrimitive buttons were calling Button::SetColors with navStrip colors that often matched the dialog body, then taking the m_useOverrides branch that skipped the auto-border. Result: non-default buttons looked like floating text. Drop the override and let buttons use theme.buttonIdleArgb/buttonBorderArgb so the rect and 1dip border always paint. Button::SetLabel now strips a single ampersand from the label (Win32 accelerator convention) and remembers the following character as the lowercase accelerator key. && becomes a literal &. DialogPrimitive handles WM_SYSCHAR and dispatches Alt+letter to the matching enabled button. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Drive-door click now opens the same themed MRU picker as the menu's Insert Disk command, including a Browse fallback to the file open dialog. Picker rows include DOS 3.3 / ProDOS so it's never empty.
Also fixes two chronic dialog issues:
&Browse...displays asBrowse...and Alt+B triggers it.