You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The purpose of this PR is to update the PRISMA config in accordance with the first submission.
Type of change
Indicate the items relevant for your PR by replacing ◻️ with ☑️. Do not delete any lines. This makes it easier to understand which areas are affected by your changes and which are not.
☑️ Configuration (switches in main.gms, default.cfg, and scenario_config*.csv files)
◻️ Other (please give a description)
Impact
☑️ Bug fix
◻️ Refactoring
◻️ New feature
◻️ Change of parameter values or input data (including CES parameters)
◻️ Minor change (default scenarios show only small differences)
◻️ Fundamental change of results of default scenarios
Checklist
Do not delete any line. Leave unfinished elements unchecked so others know how far along you are.
In the end all checkboxes must be ticked before you can merge.
I executed the automated model tests (make test) after my final commit and all tests pass (FAIL 0)
I adjusted the reporting in remind2 if and where it was needed
I adjusted the madrat packages (mrremind and other packages involved) for input data generation if and where it was needed
Yes, I think we should keep it! So we update to the latest submission?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose of this PR
The purpose of this PR is to update the PRISMA config in accordance with the first submission.
Type of change
Indicate the items relevant for your PR by replacing ◻️ with ☑️.
Do not delete any lines. This makes it easier to understand which areas are affected by your changes and which are not.
Parts concerned
Impact
Checklist
Do not delete any line. Leave unfinished elements unchecked so others know how far along you are.
In the end all checkboxes must be ticked before you can merge.
make test) after my final commit and all tests pass (FAIL 0)remind2if and where it was neededforbiddenColumnNamesin readCheckScenarioConfig.R in case the PR leads to deprecated switchesCHANGELOG.mdcorrectly (added, changed, fixed, removed, input data/calibration)Further information (optional)
/p/tmp/rahelma/cleaningexport/p/tmp/leaha/prisma/remind/output/export