Skip to content

Display least path difference in title of tabs #536

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 2, 2020
Merged

Display least path difference in title of tabs #536

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8c4c4b9
Update path through DOM query selector
ioedeveloper Oct 30, 2020
690a86a
Display least path difference in title of tabs
ioedeveloper Oct 30, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
49 changes: 47 additions & 2 deletions apps/remix-ide/src/app/panels/tab-proxy.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ export class TabProxy {
this.data = {}
this._view = {}
this._handlers = {}
this.loadedTabs = []

globalRegistry.get('themeModule').api.events.on('themeChanged', (theme) => {
// update invert for all icons
Expand Down Expand Up @@ -136,9 +137,52 @@ export class TabProxy {
if (this._handlers[name]) return

var slash = name.split('/')
if (!title) {
title = name.indexOf('/') !== -1 ? slash[slash.length - 1] : name
const tabPath = slash.reverse()
const tempTitle = []

for(let i = 0; i < tabPath.length; i++) {
tempTitle.push(tabPath[i])
const formatPath = [...tempTitle].reverse()

if(!title) {
const index = this.loadedTabs.findIndex(({ title }) => title === formatPath.join('/'))

if (index === -1) {
title = formatPath.join('/')
const titleLength = formatPath.length
this.loadedTabs.push({
name,
title
})
formatPath.shift()
if (formatPath.length > 0) {
const duplicateTabName = this.loadedTabs.find(({ title }) => title === formatPath.join('/')).name
const duplicateTabPath = duplicateTabName.split('/')
const duplicateTabFormatPath = [...duplicateTabPath].reverse()
const duplicateTabTitle = duplicateTabFormatPath.slice(0, titleLength).reverse().join('/')

this.loadedTabs.push({
name: duplicateTabName,
title: duplicateTabTitle
})
this._view.filetabs.removeTab(duplicateTabName)
this._view.filetabs.addTab({
id: duplicateTabName,
title: duplicateTabTitle,
icon,
tooltip: duplicateTabName
})
}
break;
}
} else {
this.loadedTabs.push({
name,
title
})
}
}

this._view.filetabs.addTab({
id: name,
title,
Expand All @@ -153,6 +197,7 @@ export class TabProxy {
this._view.filetabs.removeTab(name)
delete this._handlers[name]
this.switchToActiveTab()
this.loadedTabs = this.loadedTabs.filter(tab => tab.name !== name)
}

addHandler (type, fn) {
Expand Down