Skip to content

set prop-types as peerDependencies ? #5931

@HairyRabbit

Description

@HairyRabbit

Version

react-router-redux
version: 5-alpha.9

Test Case

Hi, I use the umd version in the browser with react-router-redux, it need require prop-types, is that expect?

<!DOCTYPE html>
<html>
<head>
  <meta charset="utf-8">
  <meta name="viewport" content="width=device-width">
  <title></title>
  <script src="https://unpkg.com/react@16.2.0/umd/react.development.js"></script>
  <script src="https://unpkg.com/react-router@4.2.0/umd/react-router.js"></script>
  <script src="https://unpkg.com/react-router-redux@5.0.0-alpha.9/umd/react-router-redux.js"></script>
</head>
<body>
</body>
</html>

image

jsbin

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions