Skip to content

Conversation

@gchang12
Copy link
Contributor

react-router.config.ts should not be prefixed by 'app/'

@changeset-bot
Copy link

changeset-bot bot commented Nov 16, 2025

⚠️ No Changeset found

Latest commit: 1e22d0e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@MichaelDeBoey MichaelDeBoey changed the title Fix filename docs(tutorials/address-book): fix filename Nov 17, 2025
@MichaelDeBoey MichaelDeBoey merged commit 8a243c1 into remix-run:main Nov 17, 2025
3 checks passed
brookslybrand added a commit that referenced this pull request Nov 17, 2025
brookslybrand added a commit that referenced this pull request Nov 17, 2025
@brookslybrand
Copy link
Contributor

This is incorrect, see the code for the tutorial

react-router.config.ts does not live inside of the app/ dir

I've reverted in #14563

@timdorr
Copy link
Member

timdorr commented Nov 17, 2025

I'm confused. I agree that react-router.config.ts does not live inside of the app/ path, but that is exactly what this PR is doing? We should be removing the app/ prefix, not adding it.

We have it correct above these changes: https://github.com/remix-run/react-router/blob/main/docs/tutorials/address-book.md?plain=1#L498

@brookslybrand
Copy link
Contributor

Whoops, huge brain fart, I red the green and red lines backwards 🤦‍♂️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants