Skip to content

Docs update on getComponents #1886

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 12, 2015
Merged

Docs update on getComponents #1886

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3cf3d07
update route doc
lime008 Sep 11, 2015
3f608e2
update advanced routing doc
lime008 Sep 12, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions docs/advanced/DynamicRouting.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ var CourseRoute = {
})
},

getComponents(callback) {
getComponents(location, callback) {
require.ensure([], function (require) {
callback(null, require('./components/Course'))
})
Expand All @@ -38,4 +38,4 @@ var CourseRoute = {

Now go look at what hacks you have in place to do this. Just kidding, I don't want to make you sad right now.

Run the [huge apps](https://github.com/rackt/react-router/tree/master/examples/huge-apps) example with your web inspector open and watch code get loaded in as you navigate around the demo.
Run the [huge apps](https://github.com/rackt/react-router/tree/master/examples/huge-apps) example with your web inspector open and watch code get loaded in as you navigate around the demo.
10 changes: 5 additions & 5 deletions docs/api/Route.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@ var Users = React.createClass({
});
```

#### `getComponent(callback)`
#### `getComponent(location, callback)`

Same as `component` but asynchronous, useful for
code-splitting.
Expand All @@ -107,13 +107,13 @@ code-splitting.
##### Example

```js
<Route path="courses/:courseId" getComponent={(cb) => {
<Route path="courses/:courseId" getComponent={(location, cb) => {
// do asynchronous stuff to find the components
cb(null, Course);
}}/>
```

#### `getComponents(callback)`
#### `getComponents(location, callback)`

Same as `components` but asynchronous, useful for
code-splitting.
Expand All @@ -125,7 +125,7 @@ code-splitting.
##### Example

```js
<Route path="courses/:courseId" getComponent={(cb) => {
<Route path="courses/:courseId" getComponent={(location, cb) => {
// do asynchronous stuff to find the components
cb(null, {sidebar: CourseSidebar, content: Course});
}}/>
Expand All @@ -141,4 +141,4 @@ Called when a route is about to be entered. It provides the next router state an

#### `onLeave()`

Called when a route is about to be exited.
Called when a route is about to be exited.