-
-
Notifications
You must be signed in to change notification settings - Fork 10.8k
[fixed] Added support for building URLs with optional parameters #395
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Fixes some of the issues mentioned in remix-run#290
|
I should have mentioned above this PR is not yet complete but it adds some basic functionality. |
|
Ok I have added some more tests and I am now happy with the changed behaviour. This should now be ready to go however since you mentioned in #290 that you were not sure if |
|
@dancannon This looks great! @rpflorence What do you think? Can we keep |
|
I'm for this PR with both hands! I have route |
|
Would love to get this included! For me the |
|
my only beef with If |
[fixed] Added support for building URLs with optional parameters
|
Thanks @dancannon ! |
|
Glad to help :) |
|
this is released on |
You are now able to create links with optional parameters, before if you tried to do this the following error was returned
Missing "param" parameter for path "/path/:param?".Fixes some of the issues mentioned in #290.