Skip to content

Conversation

@bluesky12
Copy link

Avoid breaking optimizations like React.PureComponent or React.memo by passing a different props.match object every time.
see #7527 for details.

@mjackson
Copy link
Member

Thanks for the PR, @bluesky12, but we are not planning on including our own deepEqual function in the router. There are a few potential fixes for this problem that you can implement in userland. I'll follow up in #7527.

@mjackson mjackson closed this Jul 19, 2021
@bluesky12
Copy link
Author

Thanks, @mjackson. Looking forward to your follow-up.

@bluesky12
Copy link
Author

Hi @mjackson, sorry to bother you again. In case I got it wrong, may I ask, did you mean you would follow up and provide an alternative solution in the near future, or did you mean you would keep following up and it might be fixed in the far future?

By the way, fixing this problem systematically in the userland seems quite tedious and hard to achieve. Every route component suffers from this issue. Every other component risks being used with Route in the future and then suffers from this issue. It would be really appreciated if we don't have to tamper around everywhere.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants