Added table-based parser for is_alphanumeric/etc functions#18
Merged
Conversation
remkade
approved these changes
Nov 10, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using a table-based parser provides better performance than the is_alpha/is_digit/etc functions in
nom. This is due to the reduced number of comparisons that are performed for each character.nom's functions work by checking if a character is within a specified range (or set of ranges), which requires multiple comparisons. The table-based lookup works by checking if the character is in one of the classes defined below, which requires only a single comparison. The table is very small (256 bytes) and is likely to remain in cache.This can be expanded upon in the future (e.g., refactoring
selector_parseto use a table), which will provide another noticeable increase in performance.