Don't lift require aliases due to our ordering rules#13
Merged
JesseHerrick merged 1 commit intomainfrom May 6, 2026
Merged
Conversation
496b62f to
b063690
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Our module directive ordering is slightly different than upstream Styler. We put
requires beforealiasalways. This means that any alias lifting that also rewritesrequireto use the alias will cause compilation to fail. To fix this, we:requiremodules. If they're written fully qualified, leave them be.requirefully qualified module calls against our fully qualified module limit before lifting the alias.Note
Low Risk
Low risk formatter change: it narrows alias-application behavior to avoid generating invalid
requiredirectives under the project’s strict ordering rules. Main impact is changed formatted output for modules that previously hadrequireshortened via lifted aliases.Overview
Prevents alias lifting/alias application from shortening
require Foo.Barintorequire Bar, sincerequires are ordered abovealiasand would otherwise reference an alias declared later (invalid Elixir).Updates expectations and adds regression coverage to ensure
requirestays fully-qualified while non-directive usages are still rewritten to the lifted alias.Reviewed by Cursor Bugbot for commit b063690. Bugbot is set up for automated code reviews on this repo. Configure here.