chore(performance): optimise field updates with large dropdown options #239
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
I think there's other general fixes that could/should be implemented to improve performance when we update fields, however this specific fix is a non-drastic way to fix the immediate problem. |
…d-contains-large-select
sandrina-p
reviewed
Oct 28, 2025
sandrina-p
reviewed
Oct 28, 2025
sandrina-p
reviewed
Oct 28, 2025
sandrina-p
reviewed
Oct 28, 2025
sandrina-p
reviewed
Oct 28, 2025
sandrina-p
previously approved these changes
Oct 28, 2025
sandrina-p
approved these changes
Oct 30, 2025
ollyd
deleted the
rmt-1768-jsf-performance-ui-lags-when-a-field-contains-large-select
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Forms containing large select option lists (e.g. country dropdown) caused severe UI lag on every keystroke in other text field inputs.
deepMergeSchemaswas recursively merging hundreds of option objects per validation.Changes:
No more discernible lag, with a measurable ~10x improvement:
Before:
After:
Related internal MR.