Skip to content

fix(player): ease player controls gradient#1742

Merged
JonnyBurger merged 3 commits intoremotion-dev:mainfrom
mickaelalvs:player-gradient
Jan 25, 2023
Merged

fix(player): ease player controls gradient#1742
JonnyBurger merged 3 commits intoremotion-dev:mainfrom
mickaelalvs:player-gradient

Conversation

@mickaelalvs
Copy link
Contributor

🤔 Why ?

Related to #1681

💻 How ?

Modification of the background on the PlayerControl. Don't know if there is a better solution to make it cleaner, don't hesitate to tell me 😊

@vercel
Copy link
Contributor

vercel bot commented Jan 25, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
remotion ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Jan 25, 2023 at 1:39PM (UTC)

@JonnyBurger
Copy link
Member

Thanks a lot! Comparing to the previous one and looking at it closely, it indeed looks a lot smoother!

This PR also darkened the gradient a lot which I was a bit concerned about since we shouldn't make too many unexpected changes in minor versions, even if they are just visual.

Therefore I reduced the opaqueness by about 30% to make it closer to before. Hope that's alright for you! ✌️

Thanks a lot for the contribution and we are ordering some samples for hoodies soon, stay tuned!

@JonnyBurger JonnyBurger enabled auto-merge January 25, 2023 13:43
@JonnyBurger JonnyBurger merged commit f8e94df into remotion-dev:main Jan 25, 2023
@mickaelalvs mickaelalvs deleted the player-gradient branch January 25, 2023 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants