Skip to content

@remotion/docs: fix homepage scroll in mobile view#2256

Merged
JonnyBurger merged 4 commits intoremotion-dev:mainfrom
Just-Moh-it:fix/homepage-scroll-mobile-safari
Jul 18, 2023
Merged

@remotion/docs: fix homepage scroll in mobile view#2256
JonnyBurger merged 4 commits intoremotion-dev:mainfrom
Just-Moh-it:fix/homepage-scroll-mobile-safari

Conversation

@Just-Moh-it
Copy link
Contributor

@Just-Moh-it Just-Moh-it commented May 15, 2023

Screen.Recording.2023-05-15.at.8.52.59.PM.mov

@vercel
Copy link
Contributor

vercel bot commented May 15, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
remotion ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 18, 2023 11:48am

@Just-Moh-it
Copy link
Contributor Author

Update–changed to draft because the width was fixed on mobile but broke on desktop

@Just-Moh-it
Copy link
Contributor Author

Mobile shouldn't break because there's enough space already, but it's breaking because link tags have padding and the find-a-template button has non-responsive margin on the left. May not require width: 100%; if we remove the padding and use flex with gap instead of margin! Will look into it soon

@JonnyBurger JonnyBurger requested a review from patsalv July 17, 2023 12:49
@patsalv patsalv changed the title fix: homepage scroll on / (mobile safari) @remotion/docs: fix homepage scroll in mobile view Jul 18, 2023
@patsalv patsalv marked this pull request as ready for review July 18, 2023 11:51
@JonnyBurger JonnyBurger merged commit d8f72d8 into remotion-dev:main Jul 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants