@remotion/google-fonts: Fix ignoreTooManyRequestsWarning option#6918
Merged
JonnyBurger merged 1 commit intoremotion-dev:mainfrom Mar 30, 2026
Merged
Conversation
Contributor
|
Reviewed PR #6918 — correct one-line bug fix that wires up the previously unused
|
![pullfrog[bot]](https://avatars.githubusercontent.com/in/1768019?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Correct fix. The ignoreTooManyRequestsWarning option was declared in the FontLoadOptions type but never actually checked in the warning condition — this PR wires it up properly.
Big Pickle (free) ｜ 𝕏
Contributor
Author
|
Hi! One of the tests failed but it looks like this failure is unrelated to my change. |
Member
|
Thank you for the fix! 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
ignoreTooManyRequestsWarningoption in@remotion/google-fontsdoes not actually suppress the console warning, even when explicitly set totrue.I updated the warning condition inside
packages/google-fonts/src/base.tsto properly respectoptions?.ignoreTooManyRequestsWarningso the warning can actually be silenced when the user explicitly configures it.