Skip to content

@remotion/studio: Fix 1px gaps between timeline video thumbnails#6948

Merged
JonnyBurger merged 1 commit intomainfrom
fix/timeline-thumbnail-gaps
Mar 31, 2026
Merged

@remotion/studio: Fix 1px gaps between timeline video thumbnails#6948
JonnyBurger merged 1 commit intomainfrom
fix/timeline-thumbnail-gaps

Conversation

@JonnyBurger
Copy link
Copy Markdown
Member

Summary

  • Compute left and right edges of each timeline thumbnail slot with Math.floor/Math.ceil respectively, so adjacent frames always touch or slightly overlap instead of leaving subpixel gaps

Test plan

  • Open a composition with a <Video> tag in the Studio timeline
  • Verify no visible 1px gaps appear between video thumbnails at various zoom levels

🤖 Generated with Claude Code

Compute left and right edges of each thumbnail slot with Math.floor/Math.ceil
respectively, so adjacent frames always touch or slightly overlap instead of
leaving subpixel gaps.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@pullfrog
Copy link
Copy Markdown
Contributor

pullfrog bot commented Mar 31, 2026

Reviewed PR #6948 — no actionable issues found. The Math.floor/Math.ceil approach correctly eliminates subpixel gaps between timeline thumbnails. Approved.

Task list (3/3 completed)
  • Read full diff and surrounding context in TimelineVideoInfo.tsx
  • Trace data flow and verify correctness of the floor/ceil approach
  • Self-critique comments and submit review

Pullfrog  | View workflow run | Triggered by Pullfrog | Using Big Pickle (free) | 𝕏

@vercel
Copy link
Copy Markdown
Contributor

vercel bot commented Mar 31, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
bugs Ready Ready Preview, Comment Mar 31, 2026 1:27pm
remotion Ready Ready Preview, Comment Mar 31, 2026 1:27pm

Request Review

@JonnyBurger JonnyBurger enabled auto-merge (squash) March 31, 2026 13:25
@JonnyBurger JonnyBurger changed the title Fix 1px gaps between timeline video thumbnails @remotion/studio: Fix 1px gaps between timeline video thumbnails Mar 31, 2026
Copy link
Copy Markdown
Contributor

@pullfrog pullfrog bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clean fix. Math.floor(left) / Math.ceil(right) guarantees left_{N+1} <= right_N for adjacent slots, so subpixel gaps are impossible — at the cost of at most 1px overlap, which is invisible for thumbnails.

Pullfrog  | View workflow run | Using Big Pickle (free) | 𝕏

@JonnyBurger JonnyBurger merged commit 35d00b6 into main Mar 31, 2026
18 of 19 checks passed
@JonnyBurger JonnyBurger deleted the fix/timeline-thumbnail-gaps branch March 31, 2026 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant