Skip to content

remotion: Make <Series> a <Sequence> with layout="none"#6952

Merged
JonnyBurger merged 2 commits intomainfrom
feature/series-is-sequence
Mar 31, 2026
Merged

remotion: Make <Series> a <Sequence> with layout="none"#6952
JonnyBurger merged 2 commits intomainfrom
feature/series-is-sequence

Conversation

@JonnyBurger
Copy link
Copy Markdown
Member

@JonnyBurger JonnyBurger commented Mar 31, 2026

Summary

  • <Series> is now a <Sequence> under the hood, accepting all <Sequence> props (from, durationInFrames, name, layout, showInTimeline, etc.)
  • Default layout is "none" so this is not a breaking change — existing code produces identical output
  • Default name is "<Series>" for timeline display
  • Added addSequenceStackTraces(Series) for proper stack traces
  • Removed ENABLE_V5_BREAKING_CHANGES gate and cleaned up tests
  • Updated docs to document the inherited props (following the <LightLeak> pattern)

Test plan

  • All 21 series tests pass
  • Verify <Series from={10}> offsets all children by 10 frames
  • Verify <Series name="my-series"> shows in Studio timeline
  • Verify stack traces point to <Series> usage site

🤖 Generated with Claude Code

@pullfrog
Copy link
Copy Markdown
Contributor

pullfrog bot commented Mar 31, 2026

Reviewed PR #6952 — no actionable issues found. The change correctly wraps <Series> children in a <Sequence layout="none">, preserving existing behavior while enabling all <Sequence> props. Approved.

Task list (5/5 completed)
  • Read the full diff and understand the changes
  • Read the full source files for context
  • Check for correctness issues — especially the layout='none' default behavior vs old behavior
  • Check for impact on exports or downstream consumers
  • Submit review or report progress

Pullfrog  | View workflow run | Triggered by Pullfrog | Using Big Pickle (free) | 𝕏

@vercel
Copy link
Copy Markdown
Contributor

vercel bot commented Mar 31, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
bugs Ready Ready Preview, Comment Mar 31, 2026 3:09pm
remotion Ready Ready Preview, Comment Mar 31, 2026 3:09pm

Request Review

Series now accepts all Sequence props (from, durationInFrames, name,
layout, showInTimeline). Default layout is "none" so existing code is
unaffected. Updated tests and docs.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Copy link
Copy Markdown
Contributor

@pullfrog pullfrog bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clean change. The wrapping <Sequence layout="none"> with default from=0 / durationInFrames=Infinity is effectively a no-op for existing users, so no breaking behavior. The ENABLE_V5_BREAKING_CHANGES gate removal and test simplification are consistent. Docs version 4.0.443 matches the next patch version correctly.

Pullfrog  | View workflow run | Using Big Pickle (free) | 𝕏

Change `export const TransitionSeries` to `const` + `export {TransitionSeries}`
so the CJS compiler doesn't turn property assignments into
`exports.TransitionSeries.X = ...`, which breaks addSequenceStackTraces.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@JonnyBurger JonnyBurger merged commit b762b94 into main Mar 31, 2026
17 of 18 checks passed
@JonnyBurger JonnyBurger deleted the feature/series-is-sequence branch March 31, 2026 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant