Skip to content

@remotion/timeline-utils: Add waveform integration tests using @mediabunny/server#7381

Merged
JonnyBurger merged 1 commit into
mainfrom
cursor/mediabunny-server-waveform-tests-3e30
May 14, 2026
Merged

@remotion/timeline-utils: Add waveform integration tests using @mediabunny/server#7381
JonnyBurger merged 1 commit into
mainfrom
cursor/mediabunny-server-waveform-tests-3e30

Conversation

@JonnyBurger
Copy link
Copy Markdown
Member

Summary

This change exercises loadWaveformPeaks end-to-end under Bun by registering @mediabunny/server, which polyfills Mediabunny’s decoders via NodeAV for server-side runtimes.

What was added

  • Root catalog entry and lockfile wiring for @mediabunny/server at 1.45.0 (aligned with the existing mediabunny catalog version).
  • @remotion/timeline-utils devDependency on @mediabunny/server so published consumers are unchanged.
  • New bun:test file src/test/load-waveform-peaks-server.test.ts that decodes https://remotion.media/dialogue.wav and checks peak sanity and progress callbacks.

Validation

  • bun test src in packages/timeline-utils
  • bun run build at repo root
  • bun run formatting in packages/timeline-utils (full stylecheck was not re-run after the oxfmt fix; timeline-utils formatting passes)

Notes

  • Tests require network access to fetch the sample URL.
  • @mediabunny/server pulls in native node-av bindings; CI must match a supported platform for those binaries.
Open in Web Open in Cursor 

@vercel
Copy link
Copy Markdown
Contributor

vercel Bot commented May 14, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
bugs Ready Ready Preview, Comment May 14, 2026 8:56am
remotion Ready Ready Preview, Comment May 14, 2026 8:56am

Request Review

Copy link
Copy Markdown
Member Author

@JonnyBurger JonnyBurger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pullfrog can you also add a test for the timeline film strip?

and test something else than .wav, to actually test a codec

@JonnyBurger JonnyBurger marked this pull request as ready for review May 14, 2026 10:38
@pullfrog
Copy link
Copy Markdown
Contributor

pullfrog Bot commented May 14, 2026

This run was cancelled 🛑

The workflow was cancelled before completion. Please check the link below for details.

Pullfrog  | View workflow run | via Pullfrog𝕏

@JonnyBurger JonnyBurger merged commit 1751e53 into main May 14, 2026
19 checks passed
@JonnyBurger JonnyBurger deleted the cursor/mediabunny-server-waveform-tests-3e30 branch May 14, 2026 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants