@remotion/layout-utils: Don't publish test files#7430
Merged
Conversation
The package builds to `dist/cjs`, but `.npmignore` only excluded `dist/test/**`, so the newly added test files landed in `dist/cjs/test` and got published. Also excludes `vitest.config.ts`. Matches the convention used by core, player, lottie and noise. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Contributor
|
This run was cancelled 🛑 The workflow was cancelled before completion. Please check the link below for details. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
4.0.463aborted becauseset-version.ts'sno-dev-filesmonorepo test failed:@remotion/layout-utilswas publishingdist/cjs/test/Root.d.tsand other test artifacts.layout-utilsbuilds todist/cjs(itstsconfigsets"outDir": "dist/cjs"), but its.npmignoreonly excludeddist/test/**.shapesworks because itsoutDiris./dist.dist/cjs/test(matching the convention incore,player,lottie,noise,lambda-client) andvitest.config.ts(matchingmedia,web-renderer) topackages/layout-utils/.npmignore.Test plan
bun test src/monorepo/no-dev-files.test.ts→ 94 pass, 0 failbun pm pack --dry-runinpackages/layout-utilsno longer lists anytest/or.ts(non-.d.ts) files🤖 Generated with Claude Code