Skip to content

@remotion/effects: Keep halftone linear gradient background#7738

Merged
JonnyBurger merged 1 commit into
mainfrom
jonnyburger/halftone-gradient-fix
May 28, 2026
Merged

@remotion/effects: Keep halftone linear gradient background#7738
JonnyBurger merged 1 commit into
mainfrom
jonnyburger/halftone-gradient-fix

Conversation

@JonnyBurger
Copy link
Copy Markdown
Member

Fixes #7734.

In solid color mode, halftoneLinearGradient() now composites dots over the incoming source instead of clearing the background between dots.

Validated with bun run build, bun run formatting, bun test src/test/effect-params.test.ts, and bunx turbo make --filter="@remotion/effects".

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@vercel
Copy link
Copy Markdown
Contributor

vercel Bot commented May 28, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
bugs Ready Ready Preview, Comment May 28, 2026 5:23am
remotion Ready Ready Preview, Comment May 28, 2026 5:23am

Request Review

Copy link
Copy Markdown
Contributor

@pullfrog pullfrog Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed changes — Fix for halftoneLinearGradient() in solid mode to preserve the background between dots by compositing over the incoming source instead of outputting transparent pixels.

  • Add sourceOver() GLSL helper — Standard premultiplied-alpha source-over compositing in the fragment shader.
  • Composite dots over background in solid mode — In colorMode: 'solid', dots are now blended over texColor rather than multiplied by coverage alone, which previously cleared the background.
  • Update docs — Clarify that solid mode composites over the previous effect in the chain.

Note: 1 inline comment(s) dropped because they did not anchor to lines inside the PR diff:

  • packages/effects/src/halftone-linear-gradient.ts:299-300 (RIGHT) — line 300 (RIGHT) is not inside a diff hunk

Pullfrog  | View workflow run | Using Kimi K2𝕏

@JonnyBurger JonnyBurger merged commit 69281fd into main May 28, 2026
17 checks passed
@JonnyBurger JonnyBurger deleted the jonnyburger/halftone-gradient-fix branch May 28, 2026 05:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

halftoneLinearGradient in "solid" mode should remain background

1 participant