@remotion/effects: Keep halftone linear gradient background#7738
Merged
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Reviewed changes — Fix for halftoneLinearGradient() in solid mode to preserve the background between dots by compositing over the incoming source instead of outputting transparent pixels.
- Add
sourceOver()GLSL helper — Standard premultiplied-alpha source-over compositing in the fragment shader. - Composite dots over background in solid mode — In
colorMode: 'solid', dots are now blended overtexColorrather than multiplied bycoveragealone, which previously cleared the background. - Update docs — Clarify that solid mode composites over the previous effect in the chain.
Note: 1 inline comment(s) dropped because they did not anchor to lines inside the PR diff:
packages/effects/src/halftone-linear-gradient.ts:299-300(RIGHT) — line 300 (RIGHT) is not inside a diff hunk
Kimi K2 | 𝕏
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Fixes #7734.
In solid color mode,
halftoneLinearGradient()now composites dots over the incoming source instead of clearing the background between dots.Validated with
bun run build,bun run formatting,bun test src/test/effect-params.test.ts, andbunx turbo make --filter="@remotion/effects".