@remotion/studio: Skip mounting volume overlay canvas when volume is default#7762
Merged
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@remotion/studio: Skip mounting volume overlay canvas when volume is default
Contributor
There was a problem hiding this comment.
✅ No new issues found.
Reviewed changes — Skip mounting the volume overlay canvas in AudioWaveform when volume is a static number rather than a dynamic string-based automation.
- Introduce
shouldRenderVolumeOverlay— Derived fromdoesVolumeChange && typeof volume === 'string', replacing the inline early-return guard inside the volume overlayuseEffect. - Conditionally render the volume canvas — The
<canvas ref={volumeCanvas}>element is now only mounted in the DOM when volume automation is present, avoiding an unnecessary DOM node. - Update effect dependencies — The volume overlay
useEffectdependency array now keys offshouldRenderVolumeOverlayinstead ofdoesVolumeChange, which is equivalent because the boolean is derived from the same inputs.
Kimi K2 | 𝕏
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
Testing
Closes #7760