Skip to content

@remotion/cli: Fix dark mode config option precedence#7769

Merged
JonnyBurger merged 3 commits into
mainfrom
cursor/fix-dark-mode-config-29cb
May 28, 2026
Merged

@remotion/cli: Fix dark mode config option precedence#7769
JonnyBurger merged 3 commits into
mainfrom
cursor/fix-dark-mode-config-29cb

Conversation

@JonnyBurger
Copy link
Copy Markdown
Member

@JonnyBurger JonnyBurger commented May 28, 2026

Fixes #7766

Summary

  • Treat an absent --dark-mode CLI flag as not provided, allowing Config.setChromiumDarkMode(true) from remotion.config.ts to take effect.
  • Preserve explicit CLI override behavior for --no-dark-mode.
  • Add regression tests for CLI parsing and renderer option precedence.

Testing

  • bun test src/test/config-chromium.test.ts
  • bun test src/test/dark-mode-option.test.ts
  • bun run build
  • bun run formatting
  • bunx remotion still src/index.ts dark-mode-test /tmp/dark-mode-config.png --log=error with temporary Config.setChromiumDarkMode(true) in packages/example/remotion.config.ts
  • ffmpeg -v error -i /tmp/dark-mode-config.png -vf crop=1:1:0:0,format=rgb24 -f rawvideo - | od -An -tx1 returned 1a 1a 1a, matching the dark-mode CSS background.
Open in Web Open in Cursor 

@vercel
Copy link
Copy Markdown
Contributor

vercel Bot commented May 28, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
bugs Ready Ready Preview, Comment May 28, 2026 7:15pm
remotion Ready Ready Preview, Comment May 28, 2026 7:15pm

Request Review

@pullfrog
Copy link
Copy Markdown
Contributor

pullfrog Bot commented May 28, 2026

This run was cancelled 🛑

The workflow was cancelled before completion. Please check the link below for details.

Pullfrog  | View workflow run | via Pullfrog𝕏

@JonnyBurger JonnyBurger merged commit 21ac6af into main May 28, 2026
16 of 18 checks passed
@JonnyBurger JonnyBurger deleted the cursor/fix-dark-mode-config-29cb branch May 28, 2026 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Config.setChromiumDarkMode doesn't work in remotion.config.ts but other options do

2 participants