Skip to content

@remotion/cli: Fix boolean config flag precedence#7771

Merged
JonnyBurger merged 1 commit into
mainfrom
cursor/fix-boolean-config-flags-29cb
May 28, 2026
Merged

@remotion/cli: Fix boolean config flag precedence#7771
JonnyBurger merged 1 commit into
mainfrom
cursor/fix-boolean-config-flags-29cb

Conversation

@JonnyBurger
Copy link
Copy Markdown
Member

@JonnyBurger JonnyBurger commented May 28, 2026

Summary

  • Use null as the absent CLI value for config-backed boolean flags that minimist otherwise defaulted to false.
  • Update matching renderer option handlers so config values are respected when the CLI flag is absent.
  • Add regression coverage for parsed CLI defaults and option precedence.

Testing

  • bun test src/test/boolean-flag-defaults.test.ts
  • bun test src/test/boolean-option-precedence.test.ts
  • bun run build
  • bun run formatting
  • bun run stylecheck (fails in @remotion/lambda-go because the VM has Go 1.22.2 and golang.org/x/crypto@v0.35.0 requires Go >= 1.23.0; this matches the known repo caveat).
Open in Web Open in Cursor 

@vercel
Copy link
Copy Markdown
Contributor

vercel Bot commented May 28, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
bugs Ready Ready Preview, Comment May 28, 2026 8:32pm
remotion Ready Ready Preview, Comment May 28, 2026 8:32pm

Request Review

@pullfrog
Copy link
Copy Markdown
Contributor

pullfrog Bot commented May 28, 2026

Pullfrog  | View workflow run | via Pullfrog | Using Kimi K2𝕏

@JonnyBurger JonnyBurger enabled auto-merge (squash) May 28, 2026 20:34
@JonnyBurger JonnyBurger merged commit 072bbe5 into main May 28, 2026
18 checks passed
@JonnyBurger JonnyBurger deleted the cursor/fix-boolean-config-flags-29cb branch May 28, 2026 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants